Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GeneralizedNewtypeDeriving (with a 'z') #2143

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Use GeneralizedNewtypeDeriving (with a 'z') #2143

merged 1 commit into from
Jan 29, 2021

Conversation

Gabriella439
Copy link
Collaborator

Fixes #2142

The extension with an 's' is not supported on GHC 8.4.4

@Gabriella439
Use GeneralizedNewtypeDeriving (with a 'z')
04e428f 
Fixes #2142

The extension with an 's' is not supported on GHC 8.4.4
@Gabriella439 Gabriella439 mentioned this pull request Jan 28, 2021
Closed
sjakobi
sjakobi approved these changes Jan 28, 2021
View reviewed changes
Copy link
Collaborator

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this wasn't caught in CI. If we want to continue to support GHC 8.4 we should probably use 8.4 in CI too.

@Gabriella439 Gabriella439 merged commit a490923 into master Jan 29, 2021
@Gabriella439 Gabriella439 deleted the gabriel/generalized branch January 29, 2021 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjakobi sjakobi sjakobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tighten base bounds on latest Dhall (1.38.0)
2 participants
@Gabriella439 @sjakobi