Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dhall-csv): add dhall csv skeleton #2214

Merged
merged 11 commits into from Jun 10, 2021
Merged

Conversation

MarcosJLR
Copy link
Collaborator

This is my first PR to the Dhall project. It just contains the required haskell and cabal files required for a new haskell package and some hello world functions to test it compiles correctly.

I also added the *.nix files but I'm not really sure about them, I just tried to mimic what was done in another package (dhall-docs). I'll keep this PR as a draft while waiting for feedback (specially on .nix files).

Copy link
Collaborator

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! :)

Please ensure that all files end with a newline though!

dhall-csv/LICENSE Outdated Show resolved Hide resolved
dhall-csv/Setup.hs Outdated Show resolved Hide resolved
dhall-csv/default.nix Outdated Show resolved Hide resolved
dhall-csv/csv-to-dhall/Main.hs Outdated Show resolved Hide resolved
dhall-csv/dhall-csv.cabal Outdated Show resolved Hide resolved
dhall-csv/dhall-csv.cabal Show resolved Hide resolved
dhall-csv/dhall-csv.cabal Outdated Show resolved Hide resolved
dhall-csv/dhall-csv.cabal Outdated Show resolved Hide resolved
scripts/release.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MarcosJLR MarcosJLR marked this pull request as ready for review June 10, 2021 16:13
@mergify mergify bot merged commit 88ad565 into master Jun 10, 2021
@mergify mergify bot deleted the feat/dhall-csv-skeleton branch June 10, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants