dhall-openapi: Fix handling of additionalProperties #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2337 Basically, `additionalProperties` is analogous to `Map Text` in `dhall`, which this change codifies. Before this change, an `object` with an `additionalProperties` field would get encoded as `Map Text Text`, regardless of what the property type was. Now the property type is correctly respected by the conversion code.
Gabriella439
added a commit
to dhall-lang/dhall-kubernetes
that referenced
this pull request
Dec 3, 2021
By pulling in the change from dhall-lang/dhall-haskell#2343
Gabriella439
added a commit
to dhall-lang/dhall-kubernetes
that referenced
this pull request
Dec 3, 2021
… by pulling in the fix from dhall-lang/dhall-haskell#2343
|
Here is the matching change to |
Gabriella439
added a commit
to dhall-lang/dhall-kubernetes
that referenced
this pull request
Dec 3, 2021
… by pulling in the fix from dhall-lang/dhall-haskell#2343
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2337
Basically,
additionalPropertiesis analogous toMap Textindhall, which this change codifies.Before this change, an
objectwith anadditionalPropertiesfield would get encoded as
Map Text Text, regardless of whatthe property type was. Now the property type is correctly
respected by the conversion code.