Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dhall-json: Don't use scientific notation for large integers #2352

Merged
merged 3 commits into from
Jan 1, 2022
Merged

dhall-json: Don't use scientific notation for large integers #2352

merged 3 commits into from
Jan 1, 2022

Conversation

Gabriella439
Copy link
Collaborator

Fixes #2351

@Gabriella439 Gabriella439 mentioned this pull request Dec 17, 2021
Closed
sjakobi
sjakobi approved these changes Dec 17, 2021
View reviewed changes
Copy link
Collaborator

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Gabriella439
Copy link
Collaborator Author

Actually, I might still make one more change to use scientific notation for floating point numbers

@Gabriella439
Copy link
Collaborator Author

So what I ended up doing is reusing the exact same logic as plain aeson (e.g. --plain mode) for pretty-printing numbers, to avoid inconsistencies in behavior between --compact and --plain

@Gabriella439 Gabriella439 merged commit 7519ab9 into master Jan 1, 2022
@Gabriella439 Gabriella439 deleted the gabriella/2351 branch January 1, 2022 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjakobi sjakobi sjakobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dhall-to-json: should --pretty vs --compact change the type of numbers in the output?
2 participants
@Gabriella439 @sjakobi