dhall-format now can output multi-line strings
#237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #229 This updates `dhall-format` to use multi-line string literals whenever pretty-printing a string with at least one newline character.
ocharles
approved these changes
Jan 28, 2018
src/Dhall/Core.hs
Outdated
| @@ -609,10 +609,35 @@ prettyNatural = Pretty.pretty | |||
| prettyDouble :: Double -> Doc ann | |||
| prettyDouble = Pretty.pretty | |||
|
|
|||
| -- TODO: Correctly escape multi-line literals | |||
There was a problem hiding this comment.
What's the todo here about? What case isn't dealt with?
There was a problem hiding this comment.
Oh, whoops! The TODO is a very real issue I still need to fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #229
This updates
dhall-formatto use multi-line string literals wheneverpretty-printing a string with at least one newline character.