Use lens-family-core instead of lens
#238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to commercialhaskell/stackage#3238 The immediate motivation of this change is to fix the upper bound issue linked above. However, since we don't need the full `lens` dependency this uses the much smaller and more stable `lens-family-core` library. Besides reducing the footprint of the `dhall` executable this should hopefully also reduce the number times we need to update the upper bound.
|
Yeah, you're right that this would not significantly reduce the footprint unless this library also migrates off of |
|
With the new caret cabal syntax this problem will hopefully fade away in a couple of years or so. Thanks for the reply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to commercialhaskell/stackage#3238
The immediate motivation of this change is to fix the upper bound issue
linked above. However, since we don't need the full
lensdependencythis uses the much smaller and more stable
lens-family-corelibrary. Besidesreducing the footprint of the
dhallexecutable this should hopefully alsoreduce the number times we need to update the upper bound.