Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add with support for Optional values #2386

Merged
merged 7 commits into from
Feb 19, 2022
Merged

Add with support for Optional values #2386

merged 7 commits into from
Feb 19, 2022

Conversation

Gabriella439
Copy link
Collaborator

… as standardized in dhall-lang/dhall-lang#1254

This completes the work initially submitted in #2373

sjakobi
sjakobi reviewed Feb 17, 2022
View reviewed changes
Copy link
Collaborator

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that some generator in our QuickCheck tests should be updated to produce the special ? label.

dhall/src/Dhall/Eval.hs Outdated Show resolved Hide resolved
sjakobi
sjakobi approved these changes Feb 19, 2022
View reviewed changes
Copy link
Collaborator

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

dhall/src/Dhall/TypeCheck.hs Outdated Show resolved Hide resolved
@Gabriella439 @sjakobi
Fix typo
9017122 
… as caught by @sjakobi

Co-authored-by: Simon Jakobi <simon.jakobi@gmail.com>
@Gabriella439 Gabriella439 merged commit 56671fe into master Feb 19, 2022
@Gabriella439 Gabriella439 deleted the gabriella/optional-with branch February 19, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjakobi sjakobi sjakobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gabriella439 @sjakobi @darichey