Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marshal Data.Text.Short.ShortText #2433

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Marshal Data.Text.Short.ShortText #2433

merged 1 commit into from
Jul 15, 2022

Conversation

j6carey
Copy link
Contributor

@j6carey j6carey commented Jul 15, 2022

...so that proto3-suite can use it as a string
representation within generated Haskell code
while still supporting Dhall marshaling.

...so that proto3-suite can use it as a string
representation within generated Haskell code
while still supporting Dhall marshaling.
Copy link
Collaborator

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already depend on text-short transitively via aeson, so the additional direct dependency doesn't seems acceptable to me.

@Gabriella439 Gabriella439 merged commit b23c526 into dhall-lang:master Jul 15, 2022
@Gabriella439
Copy link
Collaborator

Thank you! 🙂

@j6carey
Copy link
Contributor Author

j6carey commented Jul 15, 2022

Thanks for the review, and you're welcome!

@j6carey j6carey deleted the marshal-text-short branch July 15, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants