Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhall: Add Data instance to Import #2462

Merged

Conversation

JackKelly-Bellroy
Copy link
Contributor

This allows (among other things) the rewriting of Dhall expressions that contain imports, using the tools in Data.Data.Lens.

Copy link
Collaborator

@Gabriella439 Gabriella439 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! I wasn't sure if you had any other changes in mind because this is still marked as a draft PR

@JackKelly-Bellroy JackKelly-Bellroy marked this pull request as ready for review October 12, 2022 04:20
@JackKelly-Bellroy
Copy link
Contributor Author

I created it as draft so I could get a PR number to put into the changelog, then forgot to mark it as ready for review. It should be good to go now.

@Gabriella439 Gabriella439 merged commit c4a0a95 into dhall-lang:master Oct 12, 2022
@Gabriella439
Copy link
Collaborator

Awesome! Thank you for contributing this 🙂

@JackKelly-Bellroy JackKelly-Bellroy deleted the import-data-instances branch October 12, 2022 04:57
@JackKelly-Bellroy JackKelly-Bellroy restored the import-data-instances branch October 12, 2022 04:57
@JackKelly-Bellroy JackKelly-Bellroy deleted the import-data-instances branch October 13, 2022 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants