Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhall lint no longer sorts let bindings #2503

Merged
merged 2 commits into from
Apr 9, 2023
Merged

Conversation

Gabriella439
Copy link
Collaborator

Fixes #2480

This lint transformation was unsound and it seems tricky to fix, so the safe thing to do is to remove the transformation for now.

Gabriella439 and others added 2 commits April 8, 2023 08:11
Fixes #2480

This lint transformation was unsound and it seems tricky to fix, so the
safe thing to do is to remove the transformation for now.
@Gabriella439 Gabriella439 enabled auto-merge (squash) April 9, 2023 15:39
@Gabriella439 Gabriella439 merged commit 1ae72a5 into main Apr 9, 2023
@Gabriella439 Gabriella439 deleted the gabriella/rm_sortLets branch April 9, 2023 16:20
locallycompact pushed a commit to locallycompact/dhall-haskell that referenced this pull request Apr 26, 2023
Fixes dhall-lang#2480

This lint transformation was unsound and it seems tricky to fix, so the
safe thing to do is to remove the transformation for now.
locallycompact pushed a commit to locallycompact/dhall-haskell that referenced this pull request Apr 26, 2023
Fixes dhall-lang#2480

This lint transformation was unsound and it seems tricky to fix, so the
safe thing to do is to remove the transformation for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dhall lint produces ill-typed program if names are shadowed
1 participant