treewide: Raise bounds on optparse-applicative #2543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Usually I don't explicitly blacklist deprecated releases via bounds and instead rely on the fact that Cabal's solver will avoid deprecated releases |
JackKelly-Bellroy
force-pushed
the
optparse-applicative-0.18
branch
from
fcaabbd
to
3fdcad8
Compare
|
Cleaned up the bounds and force-pushed. |
|
This looks great! Thank you 😊 |
Gabriella439
approved these changes
Oct 20, 2023
|
I'd appreciate an analogous hackage revision for dhall-json. |
|
I published matching revisions for all the remaining packages (including |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optparse-applicative-0.18.0.0 is a deprecated release which used layoutSmart from package prettyprinter, which causes the runtime to blow up in certain cases.
See: pcapriotti/optparse-applicative#475 (comment)
Tested with GHC 8.10.7 using
cabal test all --constraint 'optparse-applicative == 0.18.1.0' --allow-newer=hnix:optparse-applicative --allow-newer=dhall-nixpkgs:turtle --keep-going. Doctests are failing, I'm not sure why. They also fail for me onmain.