Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switches from text-format to formatting #330

Merged
merged 6 commits into from
Mar 19, 2018
Merged

Switches from text-format to formatting #330

merged 6 commits into from
Mar 19, 2018

Conversation

jkachmar
Copy link
Contributor

text-formatting appears to be unmaintained (last commit was 2015, several PRs are sitting unmerged including one that unblocks GHC 8.4). Fortunately it looks like formatting is a drop-in replacement for it.

I've bumped stack.yaml to LTS 11.1 to pull in formatting-6.3.1 and prettyprinter-1.2.0.1, and verified that the project builds and testa pass. I also verified a successful build and test run against nightly-2018-03-18

Note that I can't seem to get cabal2nix to work, so I hand-edited the default.nix file to remove text-format and add formatting, but I'm not entirely sure if that's kosher.

@Gabriella439
Copy link
Collaborator

Gabriella439 commented Mar 19, 2018

Thanks for doing this! I will fix the build errors, so don't worry

@jkachmar
Copy link
Contributor Author

Whoops, didn't see your comment! I didn't realize that LTS 9.6 -> LTS 11.1 would bump GHC so I reverted it and added an extra dep for formatting-6.3.1, and ran the tests a few times to get an approximation of what kind of performance effects this would have (negligible, something like 1.53s vs 1.49s after 3 rounds of testing each).

@Gabriella439
Copy link
Collaborator

Gabriella439 commented Mar 19, 2018

Just merge https://github.com/jkachmar/dhall-haskell/pull/1 into your branch and then CI should pass

@Gabriella439
Copy link
Collaborator

Awesome! Thanks for fixing this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants