Support for ghc-7.10.3 / lts-6.27 #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Dhall.hs
Outdated
| @@ -9,7 +9,7 @@ | |||
| {-# LANGUAGE RecordWildCards #-} | |||
| {-# LANGUAGE ScopedTypeVariables #-} | |||
| {-# LANGUAGE StandaloneDeriving #-} | |||
| {-# LANGUAGE TypeApplications #-} | |||
| -- {-# LANGUAGE TypeApplications #-} | |||
There was a problem hiding this comment.
You can delete this line
stack.yaml
Outdated
| @@ -1,4 +1,20 @@ | |||
| resolver: lts-9.6 | |||
| resolver: lts-6.27 | |||
There was a problem hiding this comment.
Instead of modifying stack.yaml, could you create a new stack-lts-6.yaml file?
dhall.cabal
Outdated
| base >= 4.9.0.0 && < 5 , | ||
| ansi-terminal >= 0.6.3.1 && < 0.8 , | ||
| base >= 4.8.2.0 && < 5 , | ||
| ansi-terminal >= 0.6.3.1 && < 0.8 , |
There was a problem hiding this comment.
It looks like there is some unintentional whitespace at the end of this line
dhall.cabal
Outdated
| @@ -178,7 +178,9 @@ Library | |||
| text >= 0.11.1.0 && < 1.3 , | |||
| transformers >= 0.2.0.0 && < 0.6 , | |||
| unordered-containers >= 0.1.3.0 && < 0.3 , | |||
| vector >= 0.11.0.0 && < 0.13 | |||
| vector >= 0.11.0.0 && < 0.13, | |||
| semigroups >= 0.8.3.1 && < 1 | |||
There was a problem hiding this comment.
Actually, one more request: could you change this line to:
if !impl(ghc >= 8.0)
build-depends: semigroups == 0.18.*
See: https://prime.haskell.org/wiki/Libraries/Proposals/SemigroupMonoid#RecommendedVariant
|
@Gabriel439 hi, besides the requested changes, i had to add |
|
Thanks! Looks great to me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, in the process of integrate the use of dhall with eta we have needed to compile dhall with the version of ghc used to compile eta itself. In this way we can use dhall to configure eta and to configure the packages compiled with it.
Maybe a version compilable with ghc-7.10.3 could be useful for other users so we open the pr.
Fortunately all dependencies are in a suitable range and only there is a type application that needs ghc 8.
There is the option to add conditions on ghc version in the cabal file and modules but maybe it supposes too much burden. Another one would be simply create a dedicated branch. Let me know which one do you think is better.