Fix derived Inject instance for sum types
#348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #346 This fixes the `GenericInject` instance for a sum type with two constructors to include the type of the alternative constructor. For example, before this change you would get the following incorrect conversion: ``` $ cabal repl lib:dhall >>> :set -XDeriveGeneric >>> :set -XDeriveAnyClass >>> data Amount = Debit Scientific | Credit Scientific deriving (Show, Generic, Inject, Interpret) >>> Dhall.Core.pretty (embed inject (Debit 5.45)) "< Debit = { _1 = 5.45 } >" ``` ... which is missing the `Credit` alternative. After this change you get the correct result: ``` < Debit = { _1 = 5.45 } | Credit : { _1 : Double } > ```
|
I've verified that this fixes it! Getting |
|
Awesome! Thanks for verifying that :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #346
This fixes the
GenericInjectinstance for a sum type with twoconstructors to include the type of the alternative constructor. For
example, before this change you would get the following incorrect
conversion:
... which is missing the
Creditalternative.After this change you get the correct result: