Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data instance for Expr. #418

Merged
merged 6 commits into from
Jun 4, 2018
Merged

Data instance for Expr. #418

merged 6 commits into from
Jun 4, 2018

Commits on Jun 1, 2018

  1. Data instance for Expr.

    Fixes dhall-lang#416.
    
    Also adds some Template Haskell to be able to load & resolve a Dhall expression
    at compile-time.
    
    Without the `Data` instance, the AST had to be pretty-printed back to a `String`
    in the Template Haskell, and in 1.14 imports now auto-normalize, which often
    results in much larger ASTs, and therefore (at least with the current version)
    _much_ longer parses after re-serialization. Adding the `Data` instance avoids
    that.
    
    The current implementation of the `Data` instance removes
    `Data.Text.Lazy.Builder` in favor of using `Data.Text.Lazy` directly, this is
    simply because the latter already has a `Data` instance. It’s probably
    reasonable to instead have a non-derived `Data` instance for `Chunks` that
    explicitly uses `to`/`fromLazyText`, but that approach was less mechanical, so I
    punted on it.
    sellout committed Jun 1, 2018
    Configuration menu
    Copy the full SHA
    d493d7c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c92dfac View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2e7e3a6 View commit details
    Browse the repository at this point in the history
  4. Fix some typos.

    sellout committed Jun 1, 2018
    Configuration menu
    Copy the full SHA
    4e644d1 View commit details
    Browse the repository at this point in the history
  5. Add inputExprWith.

    sellout committed Jun 1, 2018
    Configuration menu
    Copy the full SHA
    3373a18 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2018

  1. Configuration menu
    Copy the full SHA
    69e4901 View commit details
    Browse the repository at this point in the history