Make format and dhall subcommands of dhall executable #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilligan
force-pushed
the
merge-in-commands
branch
from
e29265e
to
fbf0891
Compare
|
Oops, just saw the upstream changes and fixing.. |
gilligan
force-pushed
the
merge-in-commands
branch
from
fbf0891
to
8b5edac
Compare
src/Dhall/Main.hs
Outdated
| @@ -65,6 +68,13 @@ parseOptions = Options <$> parseMode <*> parseExplain <*> parsePlain | |||
| <> Options.Applicative.help "Disable syntax highlighting" | |||
| ) | |||
|
|
|||
| parseInplace = | |||
There was a problem hiding this comment.
|
@Gabriel439 i also updated Tutorial.hs, let me know if that works for you. @Fingerzam I suppose your PR was actually ready before mine. I somehow missed it. Sorry. I actually took the format subcommand code from you now but I moved hash and format to their own modules.. |
added 5 commits
June 10, 2018 12:19
makes inplace switch of format subcommand instead of global one
gilligan
force-pushed
the
merge-in-commands
branch
from
b2560e4
to
9c1cde8
Compare
|
As I mentioned in #436 I have decided to merge this pull request. Thanks to both of you, though, for taking the time to do this 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really just moved code around a bit - fixes #436
I just realized that Tutorial.hs also has to be adjusted since it is using
dhall-formatanddhall-hash. Another thing is with--inplacenow being a global switch. Is that Ok @Gabriel439 or should that rather be moved down to be a switch to theformatsubcommand?