Fix stripping of leading whitespace from multi-line strings #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #468 The code to strip leading whitespace was incorrectly computing the leading whitespace due to incorrectly escaping the string. For example, for the multi-line string: ```haskell '' foo bar '' ``` The code was escaping the newline separating `foo` and `bar` and therefore treating the multi-line string as one long line for dedenting purposes. This causes the code to incorrectly deduce that there is only one line with one leading space instead of two lines with a minimum of zero leading spaces. Fixing the code to not escape the string resolves the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #468
The code to strip leading whitespace was incorrectly computing the leading
whitespace due to incorrectly escaping the string. For example, for the
multi-line string:
The code was escaping the newline separating
fooandbarand thereforetreating the multi-line string as one long line for dedenting purposes. This
causes the code to incorrectly deduce that there is only one line with one
leading space instead of two lines with a minimum of zero leading spaces.
Fixing the code to not escape the string resolves the problem.