Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Optional and List in diffs #478

Merged
merged 2 commits into from
Jun 21, 2018
Merged

Show Optional and List in diffs #478

merged 2 commits into from
Jun 21, 2018

Conversation

Gabriella439
Copy link
Collaborator

Part of #424

This special-cases the logic for displaying type mismatches to display
Optional and List when the skeletons of the two types mismatch

For example:

$ dhall diff '{ foo : Integer }' '(Optional { foo : Integer })'
- { … : … }
+ Optional …

@Gabriella439
Show Optional and List in diffs
c836c86 
Part of #424

This special-cases the logic for displaying type mismatches to display
`Optional` and `List` when the skeletons of the two types mismatch
@Gabriella439
Merge branch 'master' into gabriel/diff_optional_list
cdffd80
@Gabriella439 Gabriella439 merged commit ae13c1d into master Jun 21, 2018
@Gabriella439 Gabriella439 deleted the gabriel/diff_optional_list branch June 21, 2018 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Gabriella439