Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loopify denote #610

Merged
merged 5 commits into from
Sep 28, 2018
Merged

Loopify denote #610

merged 5 commits into from
Sep 28, 2018

Conversation

FintanH
Copy link
Collaborator

@FintanH FintanH commented Sep 28, 2018

@sellout noticed that we were calling denote at each call of isNormalized meaning we traverse the tree superfluously.

This just uses the same technique as normalizeWith where we denote once and then check for normalization.

fwiw: This shaved 20s or so off some private benchmarks :)

Edit: 60s actually 😄

@Gabriella439
Copy link
Collaborator

Good catch! Yeah, this is a much better way of doing it! :)

@Gabriella439 Gabriella439 merged commit 365780e into dhall-lang:master Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants