Support standard version 3.0.0 and drop support for older versions #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See the discussion in dhall-lang/dhall-lang#242 and the corresponding change the standard in dhall-lang/dhall-lang#243 for more context. At some point we want to extend support for older versions of the standard as far back as possible, but in order to do this correctly we need to provide a way to systematically thread the standard version to everything that we standardize, including: * type-checking * β-normalization * α-normalization * import resolution * binary encoding/decoding ... and that entails a significant refactor to the API. Given that we need to cut a new release soon, I've decided to drop support for older releases for now. We may eventually add them back as a matter of principle to exercise backwards compatibility, albeit I expect that people are unlikely to use them again once we drop support for them once. This also changes `ProtocolVersion` to `StandardVersion` everywhere in the API and the command line for consistency with the change to the standard, since there is no longer a protocol version now that we use the standard version to version everything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the discussion in dhall-lang/dhall-lang#242
and the corresponding change the standard in
dhall-lang/dhall-lang#243 for more context.
At some point we want to extend support for older versions of the standard
as far back as possible, but in order to do this correctly we need to
provide a way to systematically thread the standard version to everything
that we standardize, including:
... and that entails a significant refactor to the API.
Given that we need to cut a new release soon, I've decided to drop support for
older releases for now. We may eventually add them back as a matter of
principle to exercise backwards compatibility, albeit I expect that people are
unlikely to use them again once we drop support for them once.
This also changes
ProtocolVersiontoStandardVersioneverywhere in the APIand the command line for consistency with the change to the standard, since
there is no longer a protocol version now that we use the standard version to
version everything.
Once this is merged I will begin the process of cutting the next release.