Union Access #657
Union Access #657
Conversation
|
@FintanH there is some info about how tests are structured in dhall-lang/dhall-lang#240. |
|
@f-f have I told you you're a hero? Thank you. I think I can see what's going on now :) |
|
Is there something I have to do when adding new files? It seems the tests couldn't find the new files, but I added them :/ |
|
@f-f ahhh of course 😅 |
src/Dhall/TypeCheck.hs
Outdated
| @@ -3273,22 +3293,70 @@ prettyTypeMessage (NotARecord lazyText0 expr0 expr1) = ErrorMessages {..} | |||
| \ Invalid: Not a record \n\ | |||
| \ \n\ | |||
| \ \n\ | |||
| \────────────────────────────────────────────────────────────────────────────────\n\ | |||
| \ \n\ | |||
| \You tried to access the field:aaa \n\ | |||
There was a problem hiding this comment.
| \You tried to access the field:aaa \n\ | |
| \You tried to access the field: \n\ |
|
@f-f Ya I thought about that, but didn't see any existing ones that had similar functionality. But that's a bad excuse really 😳 |
src/Dhall/TypeCheck.hs
Outdated
| \ \n\ | ||
| \ ┌───────────────────────────────────────────┐ \n\ | ||
| \ │ λ(r : { foo : Bool, bar : Text , baz : Natural }) → r.{ foo, bar } │ ... and so is this \n\ | ||
| \ └───────────────────────────────────────────┘ \n\ |
There was a problem hiding this comment.
Is this boxing correct? It doesn't render correctly, but that could be my browser (I use a font with ligatures that might be messing things up, though everything else looks correct.
Addressing phase 1 of dhall-lang/dhall-lang#244 and #635
@Gabriel439: I haven't implemented any tests for this and I should but is there documentation of how the tests are laid out? I'm slightly confused but possibly it'd be fine if I spent some more time looking through them :)