-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encode doubles as Double
, do bounds checks, and add support for NaN and Infinity values
#667
Conversation
…ds check when parsing
…th addition of variables prefixed with "Infinity"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I'll merge this once the upstream change to the standard is merged
I merged the changes to the standard so I think this is ready to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drvirgilio LGTM 👍
Could we add some tests that exercise the new keywords and conversions?
@f-f: I'll go ahead and merge this now and add tests later, because I need to sync this repository with the |
Actually, there are test failures on this branch that are being hidden by a CI misconfiguration on my part. I'm going to fix that first in a separate pull request and then fix the tests on this branch |
I have a pull request up against this branch with fixes to the test suite: drvirgilio#1 |
Finally got around to making a few changes:
|
@drvirgilio: Thanks for doing this! 🙂 |
See discussion in dhall-lang issue #252. I'm not sure exactly on where the parser for "[-]Infinity" should go so I kind of guessed.