Preserve Unicode characters #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dhall-lang/dhall-lang#267 According to the standard, Unicode characters up to `0x10FFFF` do not require escaping. See: https://github.com/dhall-lang/dhall-lang/blob/33cab24f8edd81b167942847a3281306204f0109/standard/dhall.abnf#L192 ... so we can preserve them when pretty-printing Dhall expressions. Note that the current code still does not comply with the standard for Unicode characters beyond `0x10FFFF`, but I'll defer fixing that to a subsequent change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dhall-lang/dhall-lang#267
According to the standard, Unicode characters up to
0x10FFFFdo notrequire escaping. See:
https://github.com/dhall-lang/dhall-lang/blob/33cab24f8edd81b167942847a3281306204f0109/standard/dhall.abnf#L192
... so we can preserve them when pretty-printing Dhall expressions.
Note that the current code still does not comply with the standard for Unicode
characters beyond
0x10FFFF, but I'll defer fixing that to a subsequentchange.