constructors === id #693
Merged
constructors === id #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FintanH: Alright, feel free to merge this now. You will need to re-freeze |
This was referenced Nov 22, 2018
|
Actually, hold off on merging this for just a few days. I'm going to cut a new minor release with the fix to |
|
Updated the branch 👌 I had to add |
|
No problem @basile-henry, that PR is so cool! The dhall-to-cabal graph 😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #635
Stage 2 of: dhall-lang/dhall-lang#244
Implements the semantics merged here: dhall-lang/dhall-lang#256
The idea is that
constructorsis equivalent to the identity function so it returns theUnionas-is. This meansconstructorsdoes not create a record of functions toUnionLits but rather utilises the newUnionaccess syntax.