Fix import caching #702
Merged
Fix import caching #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an apparently very old bug in import caching caught by @basile-henry Before this change the import resolution algorithm was: 1. Retrieving the cache 2. Transitively resolving all imports 3. Setting the new cache to be current import insert into the cache retrieved in step 1 The bug is that all of the transitive imports resolved in step 2 added entries of their own to the cache and those new cache entries were being clobbered by step 3. The fix is simple: don't use the cache retrieved in step 1 to compute the updated cache in step 3. Rather, use `modify` instead of `put` to create the new cache so that we preserve newly-added cache entries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an apparently very old bug in import caching caught by @basile-henry
Before this change the import resolution algorithm was:
step 1
The bug is that all of the transitive imports resolved in step 2 added
entries of their own to the cache and those new cache entries were being
clobbered by step 3.
The fix is simple: don't use the cache retrieved in step 1 to compute
the updated cache in step 3. Rather, use
modifyinstead ofputtocreate the new cache so that we preserve newly-added cache entries.