Fix dhall decode bug
#859
Merged
Fix dhall decode bug
#859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... as caught by @singpolyma `Dhall.Binary.unApply` was failing to uncurry functions due to the presence of `Note` constructors. This caused `dhall encode` to produce different results from `dhall hash` since the latter was normalizing the expression (and therefore removing `Note` constructors) whereas the former was not.
Gabriella439
added a commit
to dhall-lang/dhall-lang
that referenced
this pull request
Mar 16, 2019
The binary encoding specifies that curried function application needs to be stored in an uncurried form: https://github.com/dhall-lang/dhall-lang/blob/master/standard/binary.md#function-application ... however there was a bug in the Haskell implementation used to generate the reference `.dhallb` files where it was not correctly uncurrying function applications. See: dhall-lang/dhall-haskell#859 ... as a result, one of the files was encoded incorrectly, which this change fixes
Gabriella439
added a commit
to dhall-lang/dhall-lang
that referenced
this pull request
Mar 17, 2019
The binary encoding specifies that curried function application needs to be stored in an uncurried form: https://github.com/dhall-lang/dhall-lang/blob/master/standard/binary.md#function-application ... however there was a bug in the Haskell implementation used to generate the reference `.dhallb` files where it was not correctly uncurrying function applications. See: dhall-lang/dhall-haskell#859 ... as a result, one of the files was encoded incorrectly, which this change fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... as caught by @singpolyma
Dhall.Binary.unApplywas failing to uncurry functions due to the presence ofNoteconstructors. This causeddhall encodeto produce differentresults from
dhall hashsince the latter was normalizing the expression(and therefore removing
Noteconstructors) whereas the former was not.