Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix marshaling new-style union literals #918

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Fix marshaling new-style union literals #918

merged 1 commit into from
Apr 30, 2019

Conversation

Gabriella439
Copy link
Collaborator

Fixes #915

@Gabriella439 Gabriella439 mentioned this pull request Apr 30, 2019
Closed
@quasicomputational
Copy link
Collaborator

LGTM!

@Gabriella439 Gabriella439 merged commit 07c9c62 into master Apr 30, 2019
@Gabriella439 Gabriella439 deleted the gabriel/marshal_union_literals branch April 30, 2019 15:18
quasicomputational added a commit to quasicomputational/dhall-haskell that referenced this pull request May 1, 2019
@quasicomputational
Teach genericAuto about new-style union construction.
61fab2c 
I discovered it wasn't working right in dhall-lang#926. The underlying bug is
very similar to dhall-lang#915, and in fact this builds on the fix for that in dhall-lang#918.

It looks like the single-constructor case is a different underlying
bug that I don't understand just yet, so let's tackle that separately.
@quasicomputational quasicomputational mentioned this pull request May 1, 2019
Merged
quasicomputational added a commit to quasicomputational/dhall-haskell that referenced this pull request May 1, 2019
@quasicomputational
Teach genericAuto about new-style union construction.
df3b295 
The underlying bug is very similar to dhall-lang#915, and in fact this builds on
the fix for that in dhall-lang#918.

Closes dhall-lang#926.
quasicomputational added a commit to quasicomputational/dhall-haskell that referenced this pull request May 2, 2019
@quasicomputational
Teach genericAuto about new-style union construction.
205c194 
The underlying bug is very similar to dhall-lang#915, and in fact this builds on
the fix for that in dhall-lang#918.

Closes dhall-lang#926.
Gabriella439 pushed a commit that referenced this pull request May 2, 2019
@quasicomputational @Gabriella439
Teach genericAuto about new-style union construction. (#927)
c9ea8b9 
The underlying bug is very similar to #915, and in fact this builds on
the fix for that in #918.

Closes #926.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.22: union construction seems not to be normalised
2 participants
@Gabriella439 @quasicomputational