Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alpha normalization (#929) #931

Merged
merged 1 commit into from
May 2, 2019
Merged

Conversation

AndrasKovacs
Copy link
Collaborator

@AndrasKovacs AndrasKovacs commented May 2, 2019

Trivial typo fix.

Copy link
Collaborator

@Gabriella439 Gabriella439 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I kept staring at this code and couldn't find the bug 🙂

@Gabriella439
Copy link
Collaborator

I'll also cut a new release once this and all of the union-related issues are fixed

@Gabriella439 Gabriella439 merged commit 931dc50 into master May 2, 2019
@Gabriella439 Gabriella439 deleted the AndrasKovacs/fix_929 branch May 2, 2019 20:50
@ocharles
Copy link
Member

ocharles commented May 3, 2019

May I suggest turning off -fno-warn-unused?

@jneira
Copy link
Collaborator

jneira commented May 3, 2019

Also, have you considered setup a little bit slower release process with beta or/and alpha releases (for one week max?)? Not sure if it could help to avoid quick fix minor releases after major ones

@AndrasKovacs
Copy link
Collaborator Author

@ocharles agree, I intended but forgot to remove that flag

@Gabriella439
Copy link
Collaborator

@jneira: I would prefer to increase the test coverage or improve our use of the compiler/type-checker rather than slow down the release process. For example: as @ocharles suggested, this would have been caught by removing the -fno-warn-unused flag

The reason I prefer not to slow down the release process or to have stabilization periods is because in my experience it leads to less frequent releases and higher coordination costs. It also outsources the burden of quality to our users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants