New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix repl autocomplete for Records and Unions #937

Merged

Gabriella439 merged 1 commit into master from fix-repl-completion

May 4, 2019

Collaborator

basile-henry commented May 4, 2019

Remove autocomplete for Record types and Union literals as the field accessor/Union construction is not valid in these cases:

⊢ :let x = { foo : Natural, bar : Text }

x : Type

⊢ x.
x.bar  x.foo
⊢ x.bar

y : { bar : Text, foo : Natural }
it : Text

Error: Not a record or a union

x.bar
(stdin):1:1

⊢ :let y = < Foo = 3 | Bar >

y : < Foo : Natural | Bar >

⊢ y.Bar

y : { bar : Text, foo : Natural }
y : < Bar | Foo : Natural >
it : Text

Error: Not a record or a union

y.Bar
(stdin):1:1


          Fix repl autocomplete for Records and Unions

e659df9

basile-henry self-assigned this

Gabriella439 merged commit 29ccd7d into master

Gabriella439 deleted the fix-repl-completion branch

May 4, 2019 19:13

Collaborator

Gabriella439 commented May 4, 2019

Thank you 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment