[dhall-json] Isolate yaml usage behind Dhall.Yaml
#989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into eta-support
… into eta-support
|
@jneira: Great work! Thank you 🙂 |
This was referenced Jun 7, 2019
Gabriella439
pushed a commit
that referenced
this pull request
Jun 19, 2019
After #989 and #993 the use of the `yaml` package is isolated in the lib modules `Dhall.Yaml` and `Dhall.YamlToDhall` so it is easier to add support for compilers that cant use the `yaml`package like eta or ghcjs. With this one we would add support for [eta](https://eta-lang.org/), a fork of ghc that compiles to jvm bytecode. Main changes: * Add conditional to cabal file and cpp conditions to the main modules for yaml to use a specific module for eta, `Dhall.Yaml.Eta` that replaces calls to the `yaml`package to ffi calls to the java lib [jackson](https://github.com/FasterXML/jackson), one of the most popular ones in the java world. * Add the java files that contains the ffi calls * Mark `buildable: False` the subpackages that cant be built by eta for now One effect of use the cabal file for cabal and etlas (the build tool for eta) is stack and cabal builds show those warnings: ``` Warning: Cabal file warning in D:\ws\eta\dhall\dhall-haskell\dhall-json\dhall-js on.cabal@ 69:9: Unknown field: "maven-depends" Warning: Cabal file warning in D:\ws\eta\dhall\dhall-haskell\dhall-json\dhall-js on.cabal@ 74:9: Unknown field: "java-sources" ``` I've not found a way to avoid them other than use another file for etlas build (`etlas.dhall`). It would suppose duplicate most of the logic, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is prepare the package for:
yamlwithHsYaml(see Migrate to the HsYaml package #744)etaorghcjs(see https://github.com/eta-lang/dhall-haskell/tree/eta-support and https://github.com/eta-lang/dhall-haskell/tree/ghcjs-support