Skip to content
This repository has been archived by the owner on Nov 24, 2018. It is now read-only.

Add command line option to render many documents #59

Merged
merged 2 commits into from
Sep 27, 2018

Conversation

f-f
Copy link
Member

@f-f f-f commented Sep 27, 2018

Fix #58

Adds a --manyDocs command line option to render a Dhall list as a list of YAML documents in the same stream. (suggestions welcome on a better name for the option)

I opened a patch to upstream (yaml) to have access to the YAML stream events (to add DocumentStart and DocumentEnd where needed), but just concatenating strings in this way is 10x less code and it's much easier to understand/maintain (IMO)

@jneira
Copy link
Collaborator

jneira commented Sep 27, 2018

what about --split (or --list-split)? It is simpler and maybe more ambiguous, although i dont think in any overloaded meaning right now

@Gabriella439
Copy link
Collaborator

I would suggest --documents, mainly because (A) I try to avoid abbreviating words in user-facing options and (B) "many" is redundant since "docs"/"documents" is plural

@f-f
Copy link
Member Author

f-f commented Sep 27, 2018

Lovely, I'll go with --documents 👍

@Gabriella439
Copy link
Collaborator

@f-f: Looks great! Thanks for doing this 🙂

@Gabriella439 Gabriella439 merged commit 441a7d3 into dhall-lang:master Sep 27, 2018
@f-f f-f deleted the render-multiple-docs branch September 27, 2018 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants