-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nixify the build #55
Nixify the build #55
Conversation
they don't build because they require network access
Adds a Makefile that calls convert.py and runs tests By typing `nix-build` you can run all the tests and get a ./result symlink containing all the generated dhall files unanswered questions: * How to deed back the dhall files into the github repo? * Maybe we dont want to? Maybe we just want to serve it as an artifact on hydra? thoughts? Todos: * Adjust docs on building and how to use nix-shell now for interactive stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing 👏 💯 🎉
@arianvp +1 on the |
Well it is pinned to a specific Nixpkgs version, which also pins to a specific k8s version. I guess that is good enough (for now). The actual |
@arianvp I think GitHub is pretty great, because you can pin to specific commits (and I hope everyone does, since we'll have some good amount of breaking changes with #46) or tags (we don't do releases, but we'll start. I think it's a good idea to have a release just before we merge the Haskell rewrite). If there's demand for building types for multiple k8s versions, then we have several possibilities while staying on GitHub: several folders, or several branches, etc |
Also generate README in build step
Problem was that the nix-build still was secretly getting ./types ./defualt and README.md into its source closure, leading to impurity. That is fixed now. Also updated the docs on how to generate stuff.
Issues should be addressed, and there's now a single script |
I added an option to automatically update nixpkgs now @f-f I think that is all and this is ready to merge! |
@arianvp wonderful! This looks great 🙂 |
Fixes #41, fixes #4 and fixes #30
Currently uses whatever k8s version nixpkgs packages, but in my experience it is kept rather up to date.
We might want to make an
./update-nixpkgs.sh
script that quickly updates to the latestsnixpkgs-unstable
whenever we want to bump it