Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar confusion. #55

Closed
pthariensflame opened this issue Nov 8, 2017 · 1 comment
Closed

Grammar confusion. #55

pthariensflame opened this issue Nov 8, 2017 · 1 comment

Comments

@pthariensflame
Copy link

pthariensflame commented Nov 8, 2017

Reading the Dhall grammar, the following line stood out to me

text-literal = (double-quote-literal / single-quote-literal) / whitespace

Is that second / supposed to be there? I.e., is a text-literal really meant to be any of double-quote-literal or single-quote-literal or whitespace? Given the weirdness of that, and the apparently needless parentheses, I'm not so sure this was intentional…

@Gabriella439
Copy link
Contributor

Oops! Yes, that's a mistake in the grammar. It should be:

text-literal = (double-quote-literal / single-quote-literal) whitespace

Let me put out a quick pull request to fix this

Gabriella439 added a commit that referenced this issue Nov 8, 2017
Gabriella439 added a commit that referenced this issue Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants