Ensure keyword rule only matches keywords
#1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `keyword` rule is provided for PEG (and similar) parsers to exclude keywords from places like `simple-label` - and the `simple-label` rule has an example above for how to do this. However, `keyword` matches `∀`, which means that a naive use of the `keyword` rule in `simple-label` would permit simple labels such as `∀bcde`, which obviously should not be permitted. This commit splits up the `forall` rule so that `keyword` can match the forall keyword but not the forall symbol.
Gabriella439
approved these changes
May 10, 2020
Nadrieril
approved these changes
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
keywordrule is provided for PEG (and similar) parsers to excludekeywords from places like
simple-label- and thesimple-labelrulehas an example above for how to do this.
However,
keywordmatches∀, which means that a naive use of thekeywordrule insimple-labelwould permit simple labels such as∀bcde, which obviously should not be permitted.This commit splits up the
forallrule so thatkeywordcan match theforall keyword but not the forall symbol.