-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prelude): add .dhall extensions on prelude functions #1026
Merged
german1608
merged 15 commits into
dhall-lang:master
from
german1608:feat/add-dhall-extensions-to-prelude
Jul 1, 2020
Merged
feat(prelude): add .dhall extensions on prelude functions #1026
german1608
merged 15 commits into
dhall-lang:master
from
german1608:feat/add-dhall-extensions-to-prelude
Jul 1, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 14, 2020
@german1608: You can fix the CI errors by running the |
@Gabriel439 thanks! |
Gabriella439
approved these changes
Jun 14, 2020
sjakobi
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of GSoC, I'm currently building a doc generator for the dhall configuration language. One of the issues that I faced was how we should extract files from a dhall package and after several discussions with my mentors (cc: @Gabriel439 , @sjakobi and @Profpatsch) we decided to fetch files by their .dhall extension.
Currently the only files in the dhall prelude that have the .dhall extensions were the
package.dhall
files in each sub-package and it's really awkard that this tool is not compatible with the main package of dhall, so this PR attempts to add a .dhall extension on each file.I added them in a compatible way (thanks to @Gabriel439 for the idea): For each file on the package, take the
filename
and rename it tofilename.dhall
. Also create a file namedfilename
with the following contents:That way when users refer to, for example,
Prelude/Bool/and
,dhall
will look for the implementation onfilename.dhall
.The PR is really big though its a lot of the same