Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prelude): add .dhall extensions on prelude functions #1026

Merged
merged 15 commits into from
Jul 1, 2020
Merged

feat(prelude): add .dhall extensions on prelude functions #1026

merged 15 commits into from
Jul 1, 2020

Conversation

german1608
Copy link
Collaborator

@german1608 german1608 commented Jun 14, 2020

As part of GSoC, I'm currently building a doc generator for the dhall configuration language. One of the issues that I faced was how we should extract files from a dhall package and after several discussions with my mentors (cc: @Gabriel439 , @sjakobi and @Profpatsch) we decided to fetch files by their .dhall extension.

Currently the only files in the dhall prelude that have the .dhall extensions were the package.dhall files in each sub-package and it's really awkard that this tool is not compatible with the main package of dhall, so this PR attempts to add a .dhall extension on each file.

I added them in a compatible way (thanks to @Gabriel439 for the idea): For each file on the package, take the filename and rename it to filename.dhall. Also create a file named filename with the following contents:

./filename.dhall

That way when users refer to, for example, Prelude/Bool/and, dhall will look for the implementation on filename.dhall.

The PR is really big though its a lot of the same

@Gabriella439
Copy link
Contributor

@german1608: You can fix the CI errors by running the ./scripts/lint-prelude.sh script

@german1608
Copy link
Collaborator Author

@Gabriel439 thanks!

@german1608 german1608 merged commit 8799331 into dhall-lang:master Jul 1, 2020
@german1608 german1608 deleted the feat/add-dhall-extensions-to-prelude branch July 1, 2020 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants