Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code block syntax of last judgement #1039

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Conversation

german1608
Copy link
Collaborator

@german1608 german1608 commented Jul 19, 2020

The last judgment of the documentation of multiline strings rendered weirdly using indented code blocks since the line above was a list item.

This PR changes the last judgment from using indented code blocks to quoted blocks.

For a reference, this is the current documentation:

https://github.com/dhall-lang/dhall-lang/blob/master/standard/multiline.md#indentation

and this is with this patch:

https://github.com/dhall-lang/dhall-lang/blob/bf3b8fc804634124f6ebebb681e0047cbc323eb5/standard/multiline.md

just scroll to the end of the document to see the difference

@german1608 german1608 marked this pull request as ready for review July 19, 2020 01:23
Copy link
Collaborator

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof! Markdown! ;)

@german1608
Copy link
Collaborator Author

I believe I can merge this now, right @Gabriel439?

@Gabriella439
Copy link
Contributor

@german1608: Not yet. With only one implementation approving so far you would need to wait 7 days. If you get 3 implementations (a majority) to approve then you only need to wait 3 days.

@Gabriella439 Gabriella439 merged commit edcd996 into master Jul 27, 2020
@Gabriella439 Gabriella439 deleted the german/fix-multiline-docs branch July 27, 2020 01:13
@Gabriella439 Gabriella439 restored the german/fix-multiline-docs branch July 27, 2020 01:13
@Gabriella439 Gabriella439 deleted the german/fix-multiline-docs branch July 27, 2020 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants