Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 18.0.0 -> 19.0.0 #1080

Merged
merged 2 commits into from
Oct 14, 2020
Merged

Version 18.0.0 -> 19.0.0 #1080

merged 2 commits into from
Oct 14, 2020

Conversation

philandstuff
Copy link
Collaborator

It's been a month, let's have a new release.

I plan to wait for #1065. All other current PRs are in draft, so I won't wait for them (but if they're finished quickly enough, that's fine).

CHANGELOG.md Outdated Show resolved Hide resolved
@philandstuff
Copy link
Collaborator Author

I was wondering if #1073 really counts as a breaking change (I think it does but I wanted to check), and I got confused about this sentence in standard/versioning.md:

The contract for a "non-breaking" change is that any code that
parsed/resolved/type-checked/normalized successfully before must continue to do
so (modulo imported resources vanishing). The exception is the semantic
integrity check, which always changes with a new release of the standard.

This suggests that changing normalization behaviour isn't actually a breaking change (because it normalized successfully before, and it normalizes successfully after), but surely that can't be right?

Also I don't understand the second sentence - is it saying that every time we release a new version, the semantic integrity check changes? That doesn't sound right either.

@Gabriella439
Copy link
Contributor

@philandstuff: Oh, that last sentence is incorrect and is a relic from back when the input to the semantic integrity check included the standard version. Nowadays, changes to normalization behavior are breaking changes

@philandstuff philandstuff merged commit e35f69d into master Oct 14, 2020
@philandstuff philandstuff deleted the release-19.0.0 branch October 14, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants