Improve Prelude.JSON.render
output
#1118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have language support for
Text/replace
we don't needto use
Text/show
any longer. In particular, one of the limitationsof
Text/show
was that we were using it both to render valid Dhallvalues and also to render valid JSON strings, which constrained it
to produce weird output for
$
(\u0024
). However, now that wehave
Text/replace
we can use a JSON-specific escaping strategy.This also implies that we can make two further improvements (not
included in this pull request):
We could standardize the behavior of
Text/show
in terms ofText/replace
… or even remove
Text/show
as a built-in after deprecation.We can now improve the behavior of
Text/show
to escape$
as\$
instead of\u0024
… now that it's no longer used for escaping JSON strings.