Add new ⩓ operator for merging record types
#117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #92 This is the type-level analog of `∧`, which allows you to do: ``` { foo : Text } ⩓ { bar : Bool } = { foo : Text, bar : Bool } ``` The motivation for this is to allow reusing the same field types between several related records The ASCII representation of the operator is `//\\`
|
I think this has the potential to really clean up some types in dhall-to-cabal. I'm on holiday on Monday, mind postponing the merge until then? I'd love to have a read through the changes. |
|
@ocharles: Yeah, no problem. I'm in no hurry to merge. The 3 day policy is only a minimum delay if there is no discussion |
|
@ocharles: I just wanted to check if you had a chance to look at this |
|
@ocharles: Do you still want to review this before I merge? |
|
I gave it a brief look and can't think of anything. Go for it!
…On Fri, 30 Mar 2018, 5:41 pm Gabriel Gonzalez, ***@***.***> wrote:
@ocharles <https://github.com/ocharles>: Do you still want to review this
before I merge?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#117 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABRjt00xVuwsPR7UYahBCmdL8Lt7Iseks5tjmA-gaJpZM4St-V1>
.
|
Gabriella439
added a commit
to dhall-lang/dhall-haskell
that referenced
this pull request
Mar 31, 2018
... as standardized in dhall-lang/dhall-lang#117
Gabriella439
added a commit
to dhall-lang/dhall-haskell
that referenced
this pull request
Mar 31, 2018
... as standardized in dhall-lang/dhall-lang#117
geigerzaehler
pushed a commit
to geigerzaehler/dhall-vim
that referenced
this pull request
Jul 8, 2018
This operator was introduced in [this PR](dhall-lang/dhall-lang#117)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92
This is the type-level analog of
∧, which allows you to do:The motivation for this is to allow reusing the same field types between
several related records
The ASCII representation of the operator is
//\\