-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test changes for dhall-purescript #1190
Conversation
To match the non-alpha-normalized result given in tests/normalization/success/remoteSystemsB.dhall
Given that they appear at the top level, not in an import.
Since its import (Bool/package.dhall) contains imports protected by integrity checks.
This is to allow implementations to either take the type from the expression or from the annotation, without having to alpha-normalize to see that the types match for the purposes of the test.
I just checked with
But that probably just means I am running the tests wrong ( |
Excellent! Turns out I was mistakenly normalizing fully in import tests and hadn't noticed before |
@MonoidMusician Are you also running the |
Ah no, I had to skip the prelude test since my implementation is inefficient, so I probably missed something there. |
There were some minor discrepancies that kept some of the tests from passing in my dhall-purescript implementation, including some alpha normalization differences that I previously worked around in the test suite: MonoidMusician/dhall-purescript@192d6b3
This is based on my interpretation of the standard/test spec, perhaps not all of these tweaks should actually be upstreamed.