rename userHeaders -> originHeaders and add additional test case #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, the new test case doesn't actually fail because the test loader doesn't support |
timbertson
force-pushed
the
http-headers
branch
from
f613f2c
to
bd07ae1
Compare
Gabriella439
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of dhall-lang/dhall-haskell#2236 I settled on naming everything "origin headers" instead of inconsistently sometimes calling it "user headers" or "site headers". Apologies for the filename noise.
The additional test case ensures that remote imports are disallowed within
$DHALL_HEADERS, as specified in #1206