Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

betaNormalize after Text/replace to concat text and replacements #1246

Merged
merged 2 commits into from
Dec 10, 2021
Merged

betaNormalize after Text/replace to concat text and replacements #1246

merged 2 commits into from
Dec 10, 2021

Conversation

hagl
Copy link
Contributor

@hagl hagl commented Dec 3, 2021

Not completely shure about this one, but I think after the normalization of a Text/replace application, a recursive call to betaNormalize is necessary to fully normalize the TextLiteral created during the replacement.

sjakobi
sjakobi approved these changes Dec 3, 2021
View reviewed changes
Copy link
Collaborator

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@Gabriella439 Gabriella439 merged commit 502856d into dhall-lang:master Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gabriella439 Gabriella439 Gabriella439 approved these changes

@sjakobi sjakobi sjakobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hagl @Gabriella439 @sjakobi