ABNF: Fix empty lines inside the definition of rules #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From my reading of ABNF's syntax: https://datatracker.ietf.org/doc/html/rfc5234#section-4 Some whitespace is required on the following line for a rule to continue. Nadrieril/dhall-rust uses the duesee/abnf crate which seems fairly strict on this point, which means that the current abnf cannot be parsed. It looks like it's not the first time that these significant trailing whitespaces need to be re-added: 2f38c44 I assume they get removed automatically by editors therefore I am opting for a solution with no trailing whitespace but keeping the same amount of vertical space between rule options.
Gabriella439
approved these changes
Dec 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my reading of ABNF's syntax: https://datatracker.ietf.org/doc/html/rfc5234#section-4
Some whitespace is required on the following line for a rule to continue.
Nadrieril/dhall-rust uses the duesee/abnf crate which seems fairly
strict on this point, which means that the current abnf cannot be
parsed.
It looks like it's not the first time that these significant trailing
whitespaces need to be re-added:
2f38c44
I assume they get removed automatically by editors therefore I am opting
for a solution with no trailing whitespace but keeping the same amount
of vertical space between rule options.