Standardize builtin Bytes type #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also included changes to the Haskell code to work around |
|
|
||
| print encoded | ||
|
|
||
| args <- System.Environment.getArgs |
There was a problem hiding this comment.
Perhaps add a comment explaining that this is to make it easier to generate .diag files
There was a problem hiding this comment.
It actually helps to generate the *.dhallb of the testsuite; The *.diag are still generated by cbor2diab.rb.
However, I added some more documentation to the Interpret.hs module explaining how to do that.
Do you think that is sufficient?
* Currently only base-16 represenation * No functions to do something meaningful with Bytes values Fixes dhall-lang#1179
Useful to generate the *.dhallb files of the parser tests.
Apparently needed to work with the Nix installation in docker.io/nixos/nix.
Co-authored-by: Gabriella Gonzalez <GenuineGabriella@gmail.com>
mmhat
force-pushed
the
1179-standardize-bytes
branch
from
a090fd7
to
ea2155b
Compare
* Require Bytes literals to have an even length * Added test case for that * Added some more literals to the Bytes parser test case * Added documentation on how to generate *.dhallb with the included dhall executable
|
@Gabriella439 Oh, yes, the byte literals must have an even length. That was a bug in the proposal! Good catch 👍 |
Gabriella439
approved these changes
Feb 11, 2023
Co-authored-by: Gabriella Gonzalez <GenuineGabriella@gmail.com>
Gabriella439
added a commit
to dhall-lang/dhall-haskell
that referenced
this pull request
Apr 1, 2023
… as standardized in dhall-lang/dhall-lang#1323
Gabriella439
added a commit
to dhall-lang/dhall-haskell
that referenced
this pull request
Apr 2, 2023
… as standardized in dhall-lang/dhall-lang#1323
locallycompact
pushed a commit
to locallycompact/dhall-haskell
that referenced
this pull request
Apr 26, 2023
… as standardized in dhall-lang/dhall-lang#1323
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current scope of this proposal:
Fixes #1179