Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prelude: Add List/mapMaybe and Map/mapMaybe #1330

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Prelude: Add List/mapMaybe and Map/mapMaybe #1330

merged 1 commit into from
Mar 24, 2023

Conversation

JackKelly-Bellroy
Copy link
Contributor

Map/mapMaybe has proven useful when filtering maps into JSON, and wanting to discard keys instead of generating empty arrays. Added List/mapMaybe for symmetry.

Copy link
Contributor

@Gabriella439 Gabriella439 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one small suggestion

Prelude/List/mapMaybe.dhall Show resolved Hide resolved
@Gabriella439
Copy link
Contributor

alright, i'll merge this in a few days after the week waiting period is complete

@JackKelly-Bellroy
Copy link
Contributor Author

JackKelly-Bellroy commented Mar 21, 2023

I'm out and about at the moment. If I try to run lint-prelude.sh on this laptop, I will run myself out of battery, disk space, and mobile data, and I can't work out what the hydra diff is asking me to do. Would you mind pushing a commit to fix this?

(Otherwise, I will do it when I get home.)

@JackKelly-Bellroy
Copy link
Contributor Author

I remembered that cloud computing was a thing; PR re-linted and refrozen.

@Gabriella439 Gabriella439 merged commit fd057db into dhall-lang:master Mar 24, 2023
@JackKelly-Bellroy JackKelly-Bellroy deleted the mapmaybe branch March 24, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants