Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for `let` expressions with multiple `let` bindings #266

Merged
merged 2 commits into from Nov 8, 2018

Conversation

@Gabriel439
Copy link
Contributor

Gabriel439 commented Nov 6, 2018

Fixes #260

In other words, this is now legal:

let x = 1
let y = 2
in  x + y
Fixes #260

In other words, this is now legal:

```haskell
let x = 1
let y = 2
in  x + y
```
@Gabriel439

This comment has been minimized.

Copy link
Contributor Author

Gabriel439 commented Nov 6, 2018

@vapourismo

This comment has been minimized.

Copy link

vapourismo commented on 022105e Nov 6, 2018

Excellent.

@Gabriel439 Gabriel439 merged commit 17f8a93 into master Nov 8, 2018
1 check passed
1 check passed
hydra Hydra build #4712 of dhall-lang:266:dhall-lang
Details
@Gabriel439 Gabriel439 deleted the gabriel/multi_let branch Nov 8, 2018
Gabriel439 added a commit to dhall-lang/dhall-haskell that referenced this pull request Nov 10, 2018
... as standardized in: dhall-lang/dhall-lang#266

This also adds `dhall lint` support for consolidating nested `let` expressions
Gabriel439 added a commit to dhall-lang/dhall-haskell that referenced this pull request Nov 10, 2018
... as standardized in: dhall-lang/dhall-lang#266

This also adds `dhall lint` support for consolidating nested `let` expressions
Gabriel439 added a commit that referenced this pull request Nov 10, 2018
In #266 I forgot to specify how to
encode `let` expressions with multiple bindings.  This changes the encoding
to encode a `let` expression with multiple bindings as a single list with
three elements per binding.

This is not compatible with the previous encoding which would omit the type
annotation when absent instead of using `null`
@f-f f-f mentioned this pull request Nov 11, 2018
Gabriel439 added a commit that referenced this pull request Nov 13, 2018
In #266 I forgot to specify how to
encode `let` expressions with multiple bindings.  This changes the encoding
to encode a `let` expression with multiple bindings as a single list with
three elements per binding.

This is not compatible with the previous encoding which would omit the type
annotation when absent instead of using `null`
Gabriel439 added a commit to dhall-lang/dhall-haskell that referenced this pull request Nov 13, 2018
... as standardized in: dhall-lang/dhall-lang#266

This also adds `dhall lint` support for consolidating nested `let` expressions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.