Add support for let expressions with multiple let bindings
#266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #260 In other words, this is now legal: ```haskell let x = 1 let y = 2 in x + y ```
|
cc: @vapourismo |
Gabriella439
added a commit
to dhall-lang/dhall-haskell
that referenced
this pull request
Nov 10, 2018
... as standardized in: dhall-lang/dhall-lang#266 This also adds `dhall lint` support for consolidating nested `let` expressions
Gabriella439
added a commit
to dhall-lang/dhall-haskell
that referenced
this pull request
Nov 10, 2018
... as standardized in: dhall-lang/dhall-lang#266 This also adds `dhall lint` support for consolidating nested `let` expressions
Gabriella439
added a commit
that referenced
this pull request
Nov 10, 2018
In #266 I forgot to specify how to encode `let` expressions with multiple bindings. This changes the encoding to encode a `let` expression with multiple bindings as a single list with three elements per binding. This is not compatible with the previous encoding which would omit the type annotation when absent instead of using `null`
Gabriella439
added a commit
that referenced
this pull request
Nov 13, 2018
In #266 I forgot to specify how to encode `let` expressions with multiple bindings. This changes the encoding to encode a `let` expression with multiple bindings as a single list with three elements per binding. This is not compatible with the previous encoding which would omit the type annotation when absent instead of using `null`
Gabriella439
added a commit
to dhall-lang/dhall-haskell
that referenced
this pull request
Nov 13, 2018
... as standardized in: dhall-lang/dhall-lang#266 This also adds `dhall lint` support for consolidating nested `let` expressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #260
In other words, this is now legal: