Enable CORS for prelude.dhall-lang.org
#315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires several changes: First, `prelude.dhall-lang.org` needs to no longer be a redirect and should instead act as a reverse proxy using the `proxy_pass` directive. This is necessary for CORS to work since a redirect to `raw.githubusercontent.com` will cause the browser to check `raw.githubusercontent.com` for CORS support instead of consulting `prelude.dhall-lang.org` for CORS support. Second, the recommended proxy settings have to be selectively inlined to just `hydra.dhall-lang.org` because they interfere with the `prelude.dhall-lang.org` reverse proxy. Specifically, the `Host: $host` directive added by the recommended proxy settings becomes `Host: prelude.dhall-lang.org` and this confuses GitHub since GitHub treats any unrecognized `Host` header as a request to its GitHub pages functiounality. Third, we need to enable CORS with the correct `Access-Control-*` headers. This also includes a fix to the Hydra patch to work with Nixpkgs 18.09.
Gabriella439
added a commit
to dhall-lang/dhall-haskell
that referenced
this pull request
Dec 9, 2018
We can import expressions from `https://prelude.dhall-lang.org` now that it provides CORS support. See: dhall-lang/dhall-lang#315
Gabriella439
added a commit
to dhall-lang/dhall-haskell
that referenced
this pull request
Dec 10, 2018
We can import expressions from `https://prelude.dhall-lang.org` now that it provides CORS support. See: dhall-lang/dhall-lang#315
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this is so that the upcoming "Try Dhall" page can
import from the Prelude without being blocked by the browser as a
forbidden Cross-Origin request.
This requires several changes:
First,
prelude.dhall-lang.orgneeds to no longer be a redirect andshould instead act as a reverse proxy using the
proxy_passdirective.This is necessary for CORS to work since a redirect to
raw.githubusercontent.comwill cause the browser to checkraw.githubusercontent.comfor CORS support instead of consultingprelude.dhall-lang.orgfor CORS support.Second, the recommended proxy settings have to be selectively inlined
to just
hydra.dhall-lang.orgbecause they interfere with theprelude.dhall-lang.orgreverse proxy. Specifically, theHost: $hostdirective added by the recommended proxy settings becomes
Host: prelude.dhall-lang.organd this confuses GitHub sinceGitHub treats any unrecognized
Hostheader as a request to its GitHubpages functionality.
Third, we need to enable CORS with the correct
Access-Control-*headers.
This also includes a fix to the Hydra patch to work with Nixpkgs 18.09.