Add Unicode support for quoted path characters #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dhall-lang/dhall-haskell#798 This extends the range of quoted paths from ASCII to Unicode
|
Tonight, to test this, I'll attempt wrangling the submodule in |
|
@fosskers: Note that the Haskell code does not directly use the |
|
Ah, gotcha. I had assumed some futuristic scenario where the Haskell could divine a legal parser from the |
Gabriella439
added a commit
to dhall-lang/dhall-haskell
that referenced
this pull request
Jan 29, 2019
... as standardized in dhall-lang/dhall-lang#353
|
Here is the matching change to the Haskell implementation: dhall-lang/dhall-haskell#800 |
Gabriella439
added a commit
to dhall-lang/dhall-haskell
that referenced
this pull request
Feb 5, 2019
... as standardized in dhall-lang/dhall-lang#353
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dhall-lang/dhall-haskell#798
This extends the range of quoted paths from ASCII to Unicode