Don't tag encoded expressions with their version #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #335 The binary representation of Dhall expressions no longer includes the version string, which enables hash stability across standard version changes. This implies that changes to the language standard should take care to avoid reusing the same encoding to mean different things over time. This also implies that interpreters will need to make a greater effort to anticipate likely decoding failures for older expressions and provide helpful error messages.
Gabriella439
added a commit
to dhall-lang/dhall-haskell
that referenced
this pull request
Jan 31, 2019
... as standardized in dhall-lang/dhall-lang#362
|
Here's the matching change to the Haskell implementation: dhall-lang/dhall-haskell#805 |
Gabriella439
added a commit
to dhall-lang/dhall-haskell
that referenced
this pull request
Feb 4, 2019
* Remove version tag from encoded expressions ... as standardized in dhall-lang/dhall-lang#362 This includes backwards compatibility for older encoded expressions
Gabriella439
changed the title
f-f
added a commit
to f-f/dhall-clj
that referenced
this pull request
Feb 16, 2019
* Implement Text/show builtin dhall-lang/dhall-lang#365 * Don't tag encoded expressions with their version dhall-lang/dhall-lang#362 * Rename grammar rule for natural-raw: dhall-lang/dhall-lang#368
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #335
The binary representation of Dhall expressions no longer includes the
version string, which enables hash stability across standard version
changes.
This implies that changes to the language standard should take care to avoid
reusing the same encoding to mean different things over time. This also
implies that interpreters will need to make a greater effort to anticipate
likely decoding failures for older expressions and provide helpful
error messages.