Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't tag encoded expressions with their version #362
Conversation
Gabriel439
referenced this pull request
Jan 31, 2019
Closed
Store version separately from hash in integrity checks #335
Gabriel439
added a commit
to dhall-lang/dhall-haskell
that referenced
this pull request
Jan 31, 2019
Gabriel439
referenced this pull request
Jan 31, 2019
Merged
Remove version tag from encoded expressions #805
This comment has been minimized.
This comment has been minimized.
|
Here's the matching change to the Haskell implementation: dhall-lang/dhall-haskell#805 |
Gabriel439
merged commit 95fbf9c
into
master
Feb 4, 2019
1 check passed
hydra
Hydra build #7331 of dhall-lang:362:dhall-lang
Details
Gabriel439
deleted the
gabriel/no_version
branch
Feb 4, 2019
Gabriel439
added a commit
to dhall-lang/dhall-haskell
that referenced
this pull request
Feb 4, 2019
Gabriel439
changed the title
Don't tag encoded expressions with their hash
Don't tag encoded expressions with their version
Feb 15, 2019
f-f
added a commit
to f-f/dhall-clj
that referenced
this pull request
Feb 16, 2019
Gabriel439
referenced this pull request
Mar 9, 2019
Open
Surprising behaviour of StandardVersion #848
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Gabriel439 commentedJan 31, 2019
Fixes #335
The binary representation of Dhall expressions no longer includes the
version string, which enables hash stability across standard version
changes.
This implies that changes to the language standard should take care to avoid
reusing the same encoding to mean different things over time. This also
implies that interpreters will need to make a greater effort to anticipate
likely decoding failures for older expressions and provide helpful
error messages.