Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't tag encoded expressions with their version #362

Merged
merged 3 commits into from Feb 4, 2019

Conversation

Projects
None yet
2 participants
@Gabriel439
Copy link
Contributor

Gabriel439 commented Jan 31, 2019

Fixes #335

The binary representation of Dhall expressions no longer includes the
version string, which enables hash stability across standard version
changes.

This implies that changes to the language standard should take care to avoid
reusing the same encoding to mean different things over time. This also
implies that interpreters will need to make a greater effort to anticipate
likely decoding failures for older expressions and provide helpful
error messages.

Don't tag encoded expressions with their hash
Fixes #335

The binary representation of Dhall expressions no longer includes the
version string, which enables hash stability across standard version
changes.

This implies that changes to the language standard should take care to avoid
reusing the same encoding to mean different things over time.  This also
implies that interpreters will need to make a greater effort to anticipate
likely decoding failures for older expressions and provide helpful
error messages.

Gabriel439 added a commit to dhall-lang/dhall-haskell that referenced this pull request Jan 31, 2019

@Gabriel439

This comment has been minimized.

Copy link
Contributor Author

Gabriel439 commented Jan 31, 2019

Here's the matching change to the Haskell implementation: dhall-lang/dhall-haskell#805

@f-f

f-f approved these changes Jan 31, 2019

Copy link
Member

f-f left a comment

Looks great! 👏

@Gabriel439 Gabriel439 merged commit 95fbf9c into master Feb 4, 2019

1 check passed

hydra Hydra build #7331 of dhall-lang:362:dhall-lang
Details

@Gabriel439 Gabriel439 deleted the gabriel/no_version branch Feb 4, 2019

Gabriel439 added a commit to dhall-lang/dhall-haskell that referenced this pull request Feb 4, 2019

Remove version tag from encoded expressions (#805)
* Remove version tag from encoded expressions

... as standardized in dhall-lang/dhall-lang#362

This includes backwards compatibility for older encoded expressions

@Gabriel439 Gabriel439 changed the title Don't tag encoded expressions with their hash Don't tag encoded expressions with their version Feb 15, 2019

f-f added a commit to f-f/dhall-clj that referenced this pull request Feb 16, 2019

Update to latest dhall-lang
* Implement Text/show builtin
  dhall-lang/dhall-lang#365
* Don't tag encoded expressions with their version
  dhall-lang/dhall-lang#362
* Rename grammar rule for natural-raw:
  dhall-lang/dhall-lang#368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.