Expand character set for quoted labels #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This expands quoted labels to permit all non-control ASCII characters except backticks One motivation for this is that I would like to eventually standardize support for automatically converting nullary union alternatives to `Text`, but that in turn requires expanding the set of valid alternative names. A second motivation for this is to expand the set of field names that Dhall can generate when targeting JSON/YAML configurations.
f-f
approved these changes
Mar 5, 2019
Nadrieril
reviewed
Mar 5, 2019
| quoted-label = | ||
| %x20-5F | ||
| ; %x60 = "\`" | ||
| / %x61-7E |
There was a problem hiding this comment.
Looks like you lost the 1* repetition
... as caught by @Nadrieril
Gabriella439
added a commit
to dhall-lang/dhall-haskell
that referenced
this pull request
Mar 6, 2019
... as standardized in dhall-lang/dhall-lang#408
|
Here is the matching change to the Haskell implementation: dhall-lang/dhall-haskell#840 |
Gabriella439
added a commit
to dhall-lang/dhall-haskell
that referenced
this pull request
Mar 8, 2019
... as standardized in dhall-lang/dhall-lang#408
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands quoted labels to permit all non-control ASCII characters except
backticks
One motivation for this is that I would like to eventually standardize support
for automatically converting nullary union alternatives to
Text, but thatin turn requires expanding the set of valid alternative names.
A second motivation for this is to expand the set of field names that Dhall
can generate when targeting JSON/YAML configurations.